refactor: FileSystemHost.isCaseSensitive() is now required in impleme…

…ntations. BREAKING CHANGE: FileSystemHost.isCaseSensitive() is now required in implementations.
dsherret · Mar 10, 2019 · 015a124 · 015a124
1 parent f127cf4
commit 015a124
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 6 deletions.
diff --git a/lib/ts-morph.d.ts b/lib/ts-morph.d.ts
@@ -300,6 +300,8 @@ export declare class DirectoryEmitResult {
 export interface DirectoryMoveOptions extends SourceFileMoveOptions {
 }
 export interface FileSystemHost {
+    /** Gets if this file system is case sensitive. */
+    isCaseSensitive(): boolean;
     delete(path: string): Promise<void>;
     deleteSync(path: string): void;
     readDirSync(dirPath: string): string[];
@@ -319,8 +321,6 @@ export interface FileSystemHost {
     directoryExistsSync(dirPath: string): boolean;
     getCurrentDirectory(): string;
     glob(patterns: ReadonlyArray<string>): string[];
-    /** Gets if this file system is case sensitive. Defaults to true if not implemented. */
-    isCaseSensitive?(): boolean;
 }
 
 export interface ProjectOptions {

diff --git a/src/fileSystem/FileSystemHost.ts b/src/fileSystem/FileSystemHost.ts
@@ -1,4 +1,6 @@
 export interface FileSystemHost {
+    /** Gets if this file system is case sensitive. */
+    isCaseSensitive(): boolean;
     delete(path: string): Promise<void>;
     deleteSync(path: string): void;
     readDirSync(dirPath: string): string[];
@@ -18,6 +20,4 @@
     directoryExistsSync(dirPath: string): boolean;
     getCurrentDirectory(): string;
     glob(patterns: ReadonlyArray<string>): string[];
-    /** Gets if this file system is case sensitive. Defaults to true if not implemented. */
-    isCaseSensitive?(): boolean;
 }
diff --git a/src/fileSystem/VirtualFileSystemHost.ts b/src/fileSystem/VirtualFileSystemHost.ts
@@ -14,6 +14,10 @@ export class VirtualFileSystemHost implements FileSystemHost {
         this.getOrCreateDir("/");
     }
 
+    isCaseSensitive() {
+        return true;
+    }
+
     delete(path: string) {
         try {
             this.deleteSync(path);

diff --git a/src/next-major-deprecations.md b/src/next-major-deprecations.md
@@ -1,5 +1,4 @@
 # Deprecations in the next major
 
-* Remove default export from library.
-* Make `isCaseSensitive` required on `FileSystemHost`
+* None.