fix: forEachDescendant would error when the node in the callback para…

…meter was forgotten.
dsherret · Nov 11, 2018 · 152c785 · 152c785
1 parent 9576200
commit 152c785
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/src/compiler/ast/common/Node.ts b/src/compiler/ast/common/Node.ts
@@ -617,7 +617,8 @@ export class Node<NodeType extends ts.Node = ts.Node> {
             if (stop || skip || up)
                 return;
 
-            forEachChildForNode(node);
+            if (!node.wasForgotten())
+                forEachChildForNode(node);
         };
         const arrayCallback = cbNodeArray == null ? undefined : (nodes: Node[]) => {
             if (stop)

diff --git a/src/tests/compiler/common/nodeTests.ts b/src/tests/compiler/common/nodeTests.ts
@@ -1455,6 +1455,23 @@ class MyClass {
                 "" // end of file token
             ]);
         });
+
+        it("should not error when the current node is forgotten/removed", () => {
+            const {sourceFile} = getInfoFromText("class Test {} interface Test2 {}");
+            const nodeTexts: string[] = [];
+            sourceFile.forEachDescendant(node => {
+                nodeTexts.push(node.getText());
+                if (TypeGuards.isClassDeclaration(node))
+                    node.remove();
+            });
+
+            expect(nodeTexts).to.deep.equal([
+                "class Test {}",
+                "interface Test2 {}",
+                "Test2",
+                "" // end of file token
+            ]);
+        });
     });
 
     describe(nameof<Node>(n => n.getNodeProperty), () => {