fix: IndexSignatureDeclaration.getStructure() should use the node tex…

…t and not the type text.
dsherret · Sep 22, 2018 · 61f1345 · 61f1345
1 parent aea96a3
commit 61f1345
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/src/compiler/interface/IndexSignatureDeclaration.ts b/src/compiler/interface/IndexSignatureDeclaration.ts
@@ -126,8 +126,8 @@ export class IndexSignatureDeclaration extends IndexSignatureDeclarationBase<ts.
     getStructure(): IndexSignatureDeclarationStructure {
         return callBaseGetStructure<IndexSignatureDeclarationSpecificStructure>(IndexSignatureDeclarationBase.prototype, this, {
             keyName: this.getKeyName(),
-            keyType: this.getKeyType().getText(),
-            returnType: this.getReturnType().getText()
+            keyType: this.getKeyTypeNode().getText(),
+            returnType: this.getReturnTypeNode().getText()
         });
     }
 }
diff --git a/src/tests/compiler/interface/indexSignatureDeclarationTests.ts b/src/tests/compiler/interface/indexSignatureDeclarationTests.ts
@@ -229,12 +229,13 @@ describe(nameof(IndexSignatureDeclaration), () => {
         }
 
         it("should get when not has anything", () => {
-            doTest("interface Identifier { [key: string]: number; }", {
+            // use type aliases to make sure the node text and not the type text is returned
+            doTest("interface Identifier { [key: OtherType]: MyType; } type OtherType = number; type MyType = string;", {
                 isReadonly: false,
                 keyName: "key",
-                keyType: "string",
+                keyType: "OtherType",
                 docs: [],
-                returnType: "number"
+                returnType: "MyType"
             });
         });