fix: #835 - Do not create a parent directory when checking if it exists.

Fix is in TransactionalFileSystem.ts
dsherret · Jul 20, 2020 · 698a169 · 698a169
1 parent 00a16d0
commit 698a169
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/packages/bootstrap/src/SourceFileCache.ts b/packages/bootstrap/src/SourceFileCache.ts
@@ -86,7 +86,10 @@ export class SourceFileCache implements TsSourceFileContainer {
             (sourceFile as any)["scriptKind"] as ts.ScriptKind,
         );
 
-        this.fileSystemWrapper.queueMkdir(FileUtils.getDirPath(standardizedFilePath));
+        const dirPath = FileUtils.getDirPath(standardizedFilePath);
+        if (!this.fileSystemWrapper.directoryExistsSync(dirPath))
+            this.fileSystemWrapper.queueMkdir(dirPath);
+
         this.sourceFilesByFilePath.set(standardizedFilePath, sourceFile);
     }
 

diff --git a/packages/common/src/fileSystem/TransactionalFileSystem.ts b/packages/common/src/fileSystem/TransactionalFileSystem.ts
@@ -702,7 +702,9 @@ export class TransactionalFileSystem {
             return pathDir.getIsDeleted();
 
         // check if the provided path is a file or if it or its parent is deleted
-        const parentDir = this.getOrCreateParentDirectory(path);
+        const parentDir = this.getParentDirectoryIfExists(path);
+        if (parentDir == null)
+            return false;
         return parentDir.isFileQueuedForDelete(path) || parentDir.getIsDeleted();
     }