fix: Exceptions occurring when synchronously calling forgetNodesCreat…

…edInBlock weren't being thrown.

src/factories/CompilerFactory.ts

@@ -390,18 +390,24 @@ export class CompilerFactory {
      * Forgets the nodes created in the block.
      * @param block - Block of code to run.
      */
-    async forgetNodesCreatedInBlock(block: (remember: (...node: compiler.Node[]) => void) => (void | Promise<void>)) {
+    forgetNodesCreatedInBlock(block: (remember: (...node: compiler.Node[]) => void) => (void | Promise<void>)): Promise<void> {
+        // can't use the async keyword here because exceptions that happen when doing this synchronously need to be thrown
         this.nodeCache.setForgetPoint();
+        let wasPromise = false;
         try {
             const result = block((...nodes) => {
                 for (const node of nodes)
                     this.nodeCache.rememberNode(node);
             });
 
-            if (result != null && typeof result.then === "function")
-                await result;
+            if (result != null && typeof result.then === "function") {
+                wasPromise = true;
+                return result.then(() => this.nodeCache.forgetLastPoint());
+            }
         } finally {
-            this.nodeCache.forgetLastPoint();
+            if (!wasPromise)
+                this.nodeCache.forgetLastPoint();
         }
+        return Promise.resolve();
     }
 }

src/tests/tsSimpleAstTests.ts

@@ -650,6 +650,10 @@ describe(nameof(TsSimpleAst), () => {
                     expect(() => remember(classDec)).to.throw(errors.InvalidOperationError);
                 });
             });
+
+            it("should get exceptions thrown in the body", () => {
+                expect(() => ast.forgetNodesCreatedInBlock(() => { throw new Error(""); })).to.throw();
+            });
         });
 
         describe("asynchronous", async () => {