fix: #685 - Fix applyTextChanges in node 11 and 12.

dsherret · Sep 12, 2019 · e72b124 · e72b124
1 parent fe8d3a4
commit e72b124
Showing 1 changed file with 9 additions and 7 deletions.
diff --git a/src/manipulation/formatting/getTextFromFormattingEdits.ts b/src/manipulation/formatting/getTextFromFormattingEdits.ts
@@ -2,17 +2,19 @@ import { SourceFile, TextChange } from "../../compiler";
 
 export function getTextFromFormattingEdits(sourceFile: SourceFile, formattingEdits: ReadonlyArray<TextChange>) {
     // reverse the order
-    formattingEdits = [...formattingEdits].sort((a, b) => {
-        const aStart = a.getSpan().getStart();
-        const bStart = b.getSpan().getStart();
+    const reversedFormattingEdits = formattingEdits.map((edit, index) => ({ edit, index })).sort((a, b) => {
+        const aStart = a.edit.getSpan().getStart();
+        const bStart = b.edit.getSpan().getStart();
         const difference = bStart - aStart;
-        return difference === 0 ? 1 : difference;
+        if (difference === 0)
+            return a.index < b.index ? 1 : -1;
+        return difference > 0 ? 1 : -1;
     });
 
     let text = sourceFile.getFullText();
-    for (const textChange of formattingEdits) {
-        const span = textChange.getSpan();
-        text = text.slice(0, span.getStart()) + textChange.getNewText() + text.slice(span.getEnd());
+    for (const { edit } of reversedFormattingEdits) {
+        const span = edit.getSpan();
+        text = text.slice(0, span.getStart()) + edit.getNewText() + text.slice(span.getEnd());
     }
     return text;
 }