refactor: ImportDeclaration.setDefaultImport should not rename.

BREAKING CHANGE: ImportDeclaration.setDefaultImport no longer renames the identifier. Use `.renameDefaultImport` instead.
dsherret · Sep 20, 2018 · f425bd8 · f425bd8
1 parent f81f90a
commit f425bd8
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/docs/details/imports.md b/docs/details/imports.md
@@ -80,6 +80,7 @@ Set it:
 
 ```ts
 importDeclaration.setDefaultImport("MyClass");
+importDeclaration.renameDefaultImport("MyClass2");
 importDeclaration.removeDefaultImport();
 ```
 
@@ -97,7 +98,7 @@ Doing the following:
 
 ```ts
 const importDeclaration = sourceFile.getImportDeclarations()[0];
-importDeclaration.setDefaultImport("NewName");
+importDeclaration.renameDefaultImport("NewName");
 ````
 
 Will rename the default import and all its usages:

diff --git a/src/compiler/file/ImportDeclaration.ts b/src/compiler/file/ImportDeclaration.ts
@@ -71,14 +71,15 @@ export class ImportDeclaration extends Statement<ts.ImportDeclaration> {
     /**
      * Sets the default import.
      * @param text - Text to set as the default import.
+     * @remarks Use renameDefaultImport to rename.
      */
     setDefaultImport(text: string) {
         if (StringUtils.isNullOrWhitespace(text))
             return this.removeDefaultImport();
 
         const defaultImport = this.getDefaultImport();
         if (defaultImport != null) {
-            defaultImport.rename(text);
+            defaultImport.replaceWithText(text);
             return this;
         }
 

diff --git a/src/tests/compiler/file/importDeclarationTests.ts b/src/tests/compiler/file/importDeclarationTests.ts
@@ -145,11 +145,11 @@ describe(nameof(ImportDeclaration), () => {
         }
 
         it("should remove when empty", () => {
-            doTest(`import identifier from './file'; const t = identifier;`, "", `import './file'; const t = newName;`);
+            doTest(`import identifier from './file'; const t = identifier;`, "", `import './file'; const t = identifier;`);
         });
 
-        it("should rename when exists", () => {
-            doTest(`import identifier from './file'; const t = identifier;`, "newName", `import newName from './file'; const t = newName;`);
+        it("should not rename when exists", () => {
+            doTest(`import identifier from './file'; const t = identifier;`, "newName", `import newName from './file'; const t = identifier;`);
         });
 
         it("should set the default import when importing for side effects", () => {