feat: ImportDeclaration.setDefaultImport should remove the default im…

…port when providing an empty string.
dsherret · Sep 20, 2018 · f81f90a · f81f90a
1 parent 87dd9cf
commit f81f90a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/compiler/file/ImportDeclaration.ts b/src/compiler/file/ImportDeclaration.ts
@@ -73,7 +73,8 @@ export class ImportDeclaration extends Statement<ts.ImportDeclaration> {
      * @param text - Text to set as the default import.
      */
     setDefaultImport(text: string) {
-        errors.throwIfWhitespaceOrNotString(text, nameof(text));
+        if (StringUtils.isNullOrWhitespace(text))
+            return this.removeDefaultImport();
 
         const defaultImport = this.getDefaultImport();
         if (defaultImport != null) {

diff --git a/src/tests/compiler/file/importDeclarationTests.ts b/src/tests/compiler/file/importDeclarationTests.ts
@@ -144,9 +144,8 @@ describe(nameof(ImportDeclaration), () => {
             expect(sourceFile.getText()).to.equal(expected);
         }
 
-        it("should throw when whitespace", () => {
-            const { firstChild, sourceFile } = getInfoFromText<ImportDeclaration>("import d from './file';");
-            expect(() => firstChild.setDefaultImport(" ")).to.throw(errors.ArgumentNullOrWhitespaceError);
+        it("should remove when empty", () => {
+            doTest(`import identifier from './file'; const t = identifier;`, "", `import './file'; const t = newName;`);
         });
 
         it("should rename when exists", () => {