Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global namespace declaration support #443

Merged
merged 3 commits into from
Sep 29, 2018
Merged

Global namespace declaration support #443

merged 3 commits into from
Sep 29, 2018

Conversation

dsherret
Copy link
Owner

@dsherret dsherret commented Sep 29, 2018

Better support for namespace declarations that use the syntax global {}.

Deprecating:

  • .setHasNamespaceKeyword
  • .setHasModuleKeyword
  • NamespaceDeclarationStructure - hasModuleKeyword and hasNamespaceKeyword

Adding:

  • enum NamespaceDeclarationKind { Namespace = "namespace", Module = "module", Global = "global" }
  • setDeclarationKind(kind: NamespaceDeclarationKind)
  • getDeclarationKind(): NamespaceDeclarationKind;
  • NamespaceDeclarationStructure - declarationKind: NamespaceDeclarationKind

@dsherret dsherret changed the base branch from master to dev September 29, 2018 20:12
@dsherret dsherret merged commit d89fd96 into dev Sep 29, 2018
@dsherret dsherret deleted the globalNamespaceSupport branch September 29, 2018 20:24
@coveralls
Copy link

coveralls commented Sep 29, 2018

Coverage Status

Coverage decreased (-0.2%) to 95.046% when pulling cd0e511 on globalNamespaceSupport into 1ca6dd3 on dev.

dsherret added a commit that referenced this pull request May 14, 2019
BREAKING CHANGE: `NamespaceDeclaration.setHasNamespaceKeyword` and `setHasModuleKeyword` are now `setDeclarationKind(kind: NamespaceDeclarationKind)`. `NamespaceDeclarationStructure.hasModuleKeyword` and `hasNamespaceKeyword` are now `declarationKind`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants