importDeclaration.getStructure moduleSpecifier without quotes #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cancerberoSgx
commented
Oct 28, 2018
| namedImports: [{ name: "test", alias: undefined }], | ||
| namespaceImport: undefined | ||
| }); | ||
| }); | ||
| }); | ||
|
|
||
| describe(nameof<ImportDeclaration>(n => n.getStructure) + " compatibiltiy with " + |
There was a problem hiding this comment.
this test show the problem
There was a problem hiding this comment.
Thanks! I removed this though because it's superfluous. The other tests above ensure the problem won't happen and I'd prefer all tests just test one thing rather than testing multiple aspects at once.
|
Thanks a lot for the fix @cancerberoSgx! This was also incorrectly being done in export declarations so I've included that in this PR. |
|
Released now in 18.0.0. |
dsherret
pushed a commit
that referenced
this pull request
May 14, 2019
…n module specifier in structure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix incompatibility between ImportDeclaration.getStructure and moduleNode.addImportDeclaration - basically moduleSpecifier was quoted in getStructure()