Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic database listing #167

Merged
merged 6 commits into from Oct 8, 2019
Merged

Add basic database listing #167

merged 6 commits into from Oct 8, 2019

Conversation

dshoreman
Copy link
Owner

@dshoreman dshoreman commented Oct 7, 2019

Adds a basic (but filterable) table with a list of databases so the Databases item in the main sidebar menu finally has a purpose.

To get the list we add a new Database class that wraps Doctrine's DBAL which can eventually also be used to list tables etc.

This also sets up the ground work for #146.

image

Currently it only connects and provides a shortcut to the listDatabases
method, but more can be added later. This'll be enough to get something
going on the Databases page in the frontend at long last.
@dshoreman dshoreman added the enhancement New feature or request label Oct 7, 2019
@dshoreman dshoreman self-assigned this Oct 7, 2019
@dshoreman dshoreman added this to In progress in Databases via automation Oct 7, 2019
This adds a new Database module to VueX and updates the databases page
component to load data from the store and display it as a table.
For some reason env() was working in the tests but not in the actual dev
environment, so to fix that we move it to the config file instead. So
far we only seem to need the user/pass options, and host can come from
the main database connection.
Apple != ApPLe, but PHP doesn't care so it'd still work

Update database config fallbacks

This uses the primary connection's username and password as the default
values for the admin/dbal config which should fix Travis' connection
issues without having to update its .env file with the DB_ADMIN_* values

Fix database listing test

Travis uses `servidor_test` for its database name, and it's not
unreasonable to suggest other people could use different ones too,
so this asserts for more concrete examples including the current db.
@dshoreman dshoreman marked this pull request as ready for review October 8, 2019 00:20
@dshoreman dshoreman merged commit edf8b15 into develop Oct 8, 2019
Databases automation moved this from In progress to Done Oct 8, 2019
@dshoreman dshoreman deleted the databases branch October 8, 2019 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Databases
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant