Performance #98
Performance #98
Conversation
Fixed typos
Upper version and README
- move log4rs to dev-dependencies as log4rs has a large dependency tree and is only used for integration tests, and not the library itself - removed unused config and lazy_static dependencies (per cargo udeps) - added once_cell for optimizing regex init in mod.rs
as macro uses fully qualified call
Pull Request Test Coverage Report for Build 1468958305
💛 - Coveralls |
|
@jqnatividad Thank you very much for the performance improvements and sharing your code. I'm always open to code contributions and feedback. Your changes make sense and are more eloquent than what I had. Going forward, please make sure to create Pull Requests onto the Unfortunately, I don't have the time necessary to support continued development (enhancements) on this package, however if you'd like to join as a contributor of this package, you are more than welcome. Just let me know. |
|
Hi @dsietz, And yes, I'd be more than happy to help maintain and enhance test-data-generation! It fills an underserved need, and I can imagine several enhancements already. |
Hi @dsietz ,
Hope you don't mind but I took the liberty of doing a quick pass at improving performance.
I squeezed about 10% better performance from my testing with these tweaks.
BTW, I noticed that you do multi-threading in the library, is that something that can be exposed to the Data Sample Parser? Several qsv commands support multi-threading and have CLI options for it to take advantage of additional processors.
If so, let me know so I can create an enhancement issue for it.
Thanks again!