This repository has been archived by the owner on Mar 29, 2021. It is now read-only.
Next Release #204
Merged
Next Release #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update mEDRA API call to their newly updated client-side API. - Remove pointless `preventDefault` call on ReferenceList. - Update deps.
- Convert all CSS to BEM methodology + maintain backwards compatibility for old CSS classes. - Add tests for Frontend.ts - Fix issue causing tooltips to not render on Firefox or Safari. - Change to "click" style tooltips, rather than hover style (better user experience). - Minor style changes to tooltips. - Improve / refactor Frontend.ts code.
Current coverage is 79.41% (diff: 84.61%)@@ master #204 diff @@
==========================================
Files 25 25
Lines 1570 1564 -6
Methods 262 266 +4
Messages 0 0
Branches 384 379 -5
==========================================
+ Hits 1176 1242 +66
+ Misses 394 322 -72
Partials 0 0
|
- Update dependencies. - Add stylint to test workflow. - Lint all styl files.
- Convert project to yarn package manager. - Update travis.yml for yarn - Move "lint" into npm test script - Add yarn.lock to source control
- Aix-Marseille Université - Département d'études asiatiques (French) - Uppsala universitet - Historia
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
experience)
for old CSS classes
preventDefaultcall on ReferenceListFrontend.tscodeFrontend.tsStyles Added
Aix-Marseille Université - Département d'études asiatiques (French)Uppsala universitet - HistoriaCloses #203, #202