Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep package.json and yarn.lock in sync with CI #5

Merged
merged 1 commit into from
Feb 16, 2017

Conversation

dsingleton
Copy link
Owner

yarn check:

Verifies that versions of the package dependencies in the current project’s
package.json matches that of yarn’s lock file.

https://yarnpkg.com/lang/en/docs/cli/check/

Check this in CI, rather than adding to the test script, as it allows someone
to to basic things without yarn being a hard requirements. They can still:

  • run locally and install deps with npm
  • make changes and run tests using npm, as long as they don't change packages

If they add a package via npm add, or package.json then this CI check will
flag it.

`yarn check`:

> Verifies that versions of the package dependencies in the current project’s
> `package.json` matches that of yarn’s lock file.

https://yarnpkg.com/lang/en/docs/cli/check/

Check this in CI, rather than adding to the `test` script, as it allows someone
to to basic things without `yarn` being a hard requirements. They can still:
- run locally and install deps with `npm`
- make changes and run tests using `npm`, as long as they don't change packages

If they add a package via `npm add`, or `package.json` then this CI check will
flag it.
@dsingleton dsingleton merged commit 1ccdb27 into master Feb 16, 2017
@dsingleton dsingleton deleted the add-yarn-check branch February 16, 2017 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant