Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add russian translation #13

Merged
merged 2 commits into from
Jun 21, 2024
Merged

Add russian translation #13

merged 2 commits into from
Jun 21, 2024

Conversation

sklart
Copy link
Contributor

@sklart sklart commented Jun 21, 2024

Take 2 :)

@dslatt
Copy link
Owner

dslatt commented Jun 21, 2024

thanks! looks good

can you moves files to "resources/i18n/ru" folder? then Ill merge

@sklart
Copy link
Contributor Author

sklart commented Jun 21, 2024

thanks! looks good

can you moves files to "resources/i18n/ru" folder? then Ill merge

Did this. Actually, I thought there should be IETF BCP 47 language tag (https://en.wikipedia.org/wiki/IETF_language_tag) here (4 symbols), but you know better)

@dslatt
Copy link
Owner

dslatt commented Jun 21, 2024

the locales are limited by what borealis supports, so the path has to match what it expects
https://github.com/dslatt/borealis/blob/wiliwili/library/include/borealis/core/i18n.hpp

@dslatt dslatt merged commit 1d57e1e into dslatt:main Jun 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants