Resizing an element from very large to very small was not possible (corrected) #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le because the resulting size deviated from the mouse position, especially in case of small grid dimensions
This reverts commit 1c84797. (as asked by @fixmycode for PR dsmorse#112)
This reverts commit 8639a29. (as asked by @fixmycode for PR dsmorse#112)
|
Alex, thanks for doing the changed that I asked for. The unit tests are all passing which is great but as this changes some core things in terms of user interaction that can't be correctly tested automatically, I'll merge them after I give them a try on the weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fixmycode, this is a resubmission of #112 where I left only the change required to fix the problem (version information etc. from #112 is not included)