New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2423 Ozon Content: Tabel toevoegingen STOP implementeren inOzon documentweergave #2577
#2423 Ozon Content: Tabel toevoegingen STOP implementeren inOzon documentweergave #2577
Conversation
cedada3
to
9d114e5
Compare
c4c0365
to
194f2fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ik neem aan dat dit PR mergemateriaal is? Ik mis nog een CHANGELOG, ik zie comments, en je geeft aan dat niet alles is geimplementeerd: heb je dit met UX besproken?
In grote lijnen begrijp ik wat er gebeurt. Maandag samen afmutsen.
packages/dso-toolkit/src/components/ozon-content/ozon-content.content.ts
Show resolved
Hide resolved
packages/core/src/components/ozon-content/nodes/table.node/table.node.tsx
Outdated
Show resolved
Hide resolved
packages/core/src/components/ozon-content/nodes/table.node/table-cell.tsx
Outdated
Show resolved
Hide resolved
packages/core/src/components/ozon-content/nodes/table.node/table-cell.tsx
Outdated
Show resolved
Hide resolved
packages/core/src/components/ozon-content/nodes/table.node/colspec/colspec-mapper.ts
Show resolved
Hide resolved
1e9d0e2
to
137ad32
Compare
dab641b
to
0d5ff49
Compare
0d5ff49
to
fe958aa
Compare
packages/core/src/components/ozon-content/nodes/table.node/table-cell.tsx
Show resolved
Hide resolved
packages/core/src/components/ozon-content/nodes/table.node/table-cell.tsx
Show resolved
Hide resolved
0d5ff49
to
2efd7db
Compare
2efd7db
to
85a63d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dit is top!
…Ozon documentweergave
85a63d8
to
f2c592b
Compare
In deze PR zijn geïmplementeerd 3 van de 6 attributen beschreven in het issue #2423. Te weten rowsep, colsep en frame. Mbt. tot de attributen tabstyle en orient zijn er geen voorbeelden gevonden, waarop dit van toepassing is.
Mbt. attribuut pgwide: deze lijkt geen betekenis te hebben binnen de context van DSO.