Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2423 Ozon Content: Tabel toevoegingen STOP implementeren inOzon documentweergave #2577

Conversation

iterox
Copy link
Contributor

@iterox iterox commented Mar 11, 2024

In deze PR zijn geïmplementeerd 3 van de 6 attributen beschreven in het issue #2423. Te weten rowsep, colsep en frame. Mbt. tot de attributen tabstyle en orient zijn er geen voorbeelden gevonden, waarop dit van toepassing is.
Mbt. attribuut pgwide: deze lijkt geen betekenis te hebben binnen de context van DSO.

@iterox iterox force-pushed the #2423-Ozon-Content--Tabel-toevoegingen-STOP-implementeren-in-Ozon-documentweergave branch from cedada3 to 9d114e5 Compare March 11, 2024 14:22
@iterox iterox added the ✨ feature New feature label Mar 12, 2024
@iterox iterox requested a review from hansgrimm March 12, 2024 13:43
hansgrimm
hansgrimm previously approved these changes Mar 12, 2024
@tfrijsewijk tfrijsewijk force-pushed the master branch 8 times, most recently from c4c0365 to 194f2fc Compare March 18, 2024 12:27
Copy link
Member

@tfrijsewijk tfrijsewijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ik neem aan dat dit PR mergemateriaal is? Ik mis nog een CHANGELOG, ik zie comments, en je geeft aan dat niet alles is geimplementeerd: heb je dit met UX besproken?

In grote lijnen begrijp ik wat er gebeurt. Maandag samen afmutsen.

@iterox iterox force-pushed the #2423-Ozon-Content--Tabel-toevoegingen-STOP-implementeren-in-Ozon-documentweergave branch from 1e9d0e2 to 137ad32 Compare March 21, 2024 10:30
@iterox iterox force-pushed the #2423-Ozon-Content--Tabel-toevoegingen-STOP-implementeren-in-Ozon-documentweergave branch 3 times, most recently from dab641b to 0d5ff49 Compare March 25, 2024 13:37
@iterox iterox requested a review from tfrijsewijk March 25, 2024 13:40
@iterox iterox force-pushed the #2423-Ozon-Content--Tabel-toevoegingen-STOP-implementeren-in-Ozon-documentweergave branch from 0d5ff49 to fe958aa Compare March 27, 2024 09:31
@iterox iterox force-pushed the #2423-Ozon-Content--Tabel-toevoegingen-STOP-implementeren-in-Ozon-documentweergave branch 3 times, most recently from 0d5ff49 to 2efd7db Compare March 29, 2024 07:45
@iterox iterox force-pushed the #2423-Ozon-Content--Tabel-toevoegingen-STOP-implementeren-in-Ozon-documentweergave branch from 2efd7db to 85a63d8 Compare March 29, 2024 07:48
@iterox iterox requested a review from tfrijsewijk March 29, 2024 07:49
Copy link
Member

@tfrijsewijk tfrijsewijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dit is top!

@tfrijsewijk tfrijsewijk force-pushed the #2423-Ozon-Content--Tabel-toevoegingen-STOP-implementeren-in-Ozon-documentweergave branch from 85a63d8 to f2c592b Compare March 29, 2024 11:55
@tfrijsewijk tfrijsewijk merged commit f2c592b into master Mar 29, 2024
1 of 2 checks passed
@tfrijsewijk tfrijsewijk deleted the #2423-Ozon-Content--Tabel-toevoegingen-STOP-implementeren-in-Ozon-documentweergave branch March 29, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ozon Content: Tabel toevoegingen STOP implementeren in Ozon documentweergave
3 participants