New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix to bit shift errors #1
Conversation
Pull Request Test Coverage Report for Build 17
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build 17
💛 - Coveralls |
Thanks for catching this. I'd really like one of us to reproduce the issue in a unit-test. Would you be willing to add one, or would you prefer that I do? |
Thanks for responding! I do not understand ext4 that well yet to unit test this bug. |
Did you actually experience the failures, or merely just observe the bugs while looking at the code? If the former, where in the code did it fail for you? |
I just observed the bugs. Did not actually get it to cause any failure. |
Good catch.
…On Mon, May 27, 2019, 14:19 Ayush Ranjan ***@***.*** wrote:
I just observed the bugs. Did not actually get it to cause any failure.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1?email_source=notifications&email_token=AAFOW2UX6RCRVUBXGWTYMSLPXQQ3TA5CNFSM4HPS2WS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWKKC4Y#issuecomment-496279923>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAFOW2UYVABNH5COOA7TPC3PXQQ3TANCNFSM4HPS2WSQ>
.
|
In lieu of the fact that we don't have a failure case that we can write a test for, I'll just merge it. Thanks. |
As corrected in this PR, at many instances in the code a 32-bit or 16-bit number was being left shifted by 32. The numeric values were too small for that to be a valid shift.
I have just moved the shifts outside of the
uint64
cast which should fix this issue.