Free Data Blocks #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 24
💛 - Coveralls |
Pull Request Test Coverage Report for Build 23
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build 23
💛 - Coveralls |
dsoprea
previously approved these changes
Jun 13, 2019
dsoprea
dismissed
their stale review
Do me a favor and add a unit-test for this to superblock_test.go .
|
Added unit test. |
|
Coveralls is still complaining but that looks like a decimal error. I think the test coverage is unchanged. You can probably merge past that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It'd be nice to have a getter function for the number of free data blocks in the fs.