Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PVLib ForecastModel class #28

Closed
aashishyadavally opened this issue May 2, 2019 · 2 comments
Closed

PVLib ForecastModel class #28

aashishyadavally opened this issue May 2, 2019 · 2 comments

Comments

@aashishyadavally
Copy link
Contributor

@Anirudh-Kakarlapudi , @Jayant1234 :

Considering we are using, from einstein.models import pvlib, which in turn uses 'from pvlib.forecast import ForecastModel' - the problem is that pvlib currently says the ForecastModel API that we are importing will need maintenance, as they are planning to move the whole API into an io.

Thus, each time we run the module, the ForecastModel warning pops up. To avoid this, I was thinking I will move the from einstein.models import pvlib import into the --model=pvlib switch-case construct in the __main__.py script, which will ensure that the warning pops up only when the user chooses to run the PVLib models through einstein.

How do you think?

@Jayant1234
Copy link
Contributor

It will definitely improve the project's professional packaging. Nice consideration.

@aashishyadavally
Copy link
Contributor Author

Sure. Will go ahead and do that! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants