Address Validation moved to static method #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… static function. This allows testing of an ipv6 address (to be valid or not) without throwing an exception.
Moved the validation of an IPv6 address from the constructor to the new public static method. This allows testing of an address to be valid or not without throwing an exception when creating an instance of the ipv6address object.
|
Modified the commit message. Hope it is ok now... (as me being a complete git newbie, used to subversion) |
Corrected method documentation to properly define param and return value of the validation ipv6 method
Modified the validation in class methods to use the (new) public static validate method from the v6tools\IPv6Address class
Added 2 unittests for testing the public static method validate in IPv6Address vclass
Replaced logical and for or in checking validity of ipv6 prefix length
dsp
added a commit
that referenced
this pull request
Jun 21, 2011
Address Validation moved to static method
|
thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the validation of the ipv6 address in the construct to a public static method. This allows testing of an ipv6 address (to be valid or not) without throwing an exception.