Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blacklist effectiveness #1

Closed
grahamperrin opened this issue Apr 22, 2019 · 2 comments
Closed

Blacklist effectiveness #1

grahamperrin opened this issue Apr 22, 2019 · 2 comments

Comments

@grahamperrin
Copy link

I added the extension to Waterfox 56.2.8, blacklisted google.com, felt lucky at https://www.google.com/ … arrived at https://www.google.com/doodles/ and found Google Doodles in history.

Do I misunderstand the blacklist?

@dsrini-open
Copy link
Owner

The blacklist history will be auto-deleted on any Window close - if the option is selected (by default selected) in Settings. I didn't want to remove the history on every tab close or prevent adding the page visited to history itself.
Firefox doesn't seem to recognize the window close option when it is the last window. You can either trigger the deletion manually by "Remove Blacklist history" or by "Remove for google.com". Or if you close any second open window, extension will automatically clear the blacklisted ones. I am thinking of changing this to auto-clear history on window open, so when firefox opens it clears the previous history, as a hack to the current situation. Please verify, and let me know if the issue still persists.

@dsrini-open
Copy link
Owner

Auto-removal feature is provided with white-listed domains.
Black-list also removes history but on window close.
Please review and update / provide a feedback.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants