Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize PipelineBase on factory pattern #85

Closed
thcrock opened this issue Mar 31, 2017 · 0 comments
Closed

Standardize PipelineBase on factory pattern #85

thcrock opened this issue Mar 31, 2017 · 0 comments
Assignees
@thcrock
Milestone
v0.3

Comments

@thcrock
Copy link
Contributor

thcrock commented Mar 31, 2017

Utilizing the factory pattern for all serializable component (ie FeatureGenerator, LabelGenerator, ModelTrainer) arguments makes parallel processing much easier. The prediction/evaluation loop is implemented in a more hackneyed and verbose way; we can convert this, as well as all other components, in one fell swoop to improve readability and future parallelization.
@thcrock thcrock self-assigned this Mar 31, 2017
thcrock added a commit that referenced this issue Mar 31, 2017
@thcrock
Standardize pipeline components on factory pattern [Resolves #85]
635b57b 
No functional change here, just some refactoring to make multiprocessing easier across the board

- Create factories for all components when pipeline is instantiated
- Refactor prediction/evaluations multiprocessing to use Predictor and ModelScorer factories
@thcrock thcrock added this to the v0.3 milestone Apr 5, 2017
thcrock pushed a commit that referenced this issue Apr 6, 2017
@thcrock
Standardize pipeline components on factory pattern [Resolves #85]
9c1e2dc 
No functional change here, just some refactoring to make multiprocessing easier across the board

- Create factories for all components when pipeline is instantiated
- Refactor prediction/evaluations multiprocessing to use Predictor and ModelScorer factories
@thcrock thcrock closed this as completed in 259af31 Apr 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thcrock thcrock

Labels
None yet
Projects
None yet
Milestone
v0.3
Development

No branches or pull requests
1 participant
@thcrock