Skip to content

Commit

Permalink
Set OCI disk sizes properly
Browse files Browse the repository at this point in the history
  • Loading branch information
jvstme committed May 21, 2024
1 parent 568d661 commit a3c27ff
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
1 change: 1 addition & 0 deletions src/dstack/_internal/core/backends/oci/compute.py
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,7 @@ def create_instance(
display_name=instance_config.instance_name,
cloud_init_user_data=get_user_data(instance_config.get_public_keys()),
shape=instance_offer.instance.name,
disk_size_gb=round(instance_offer.instance.resources.disk.size_mib / 1024),
image_id=image_id,
)
except oci.exceptions.ServiceError as e:
Expand Down
7 changes: 5 additions & 2 deletions src/dstack/_internal/core/backends/oci/resources.py
Original file line number Diff line number Diff line change
Expand Up @@ -236,9 +236,9 @@ def launch_instance(
display_name: str,
cloud_init_user_data: str,
shape: str,
disk_size_gb: int,
image_id: str,
) -> oci.core.models.Instance:
# TODO(#1194): allow setting disk size
return region.compute_client.launch_instance(
oci.core.models.LaunchInstanceDetails(
availability_domain=availability_domain,
Expand All @@ -252,7 +252,10 @@ def launch_instance(
user_data=base64.b64encode(cloud_init_user_data.encode()).decode(),
),
shape=shape,
source_details=oci.core.models.InstanceSourceViaImageDetails(image_id=image_id),
source_details=oci.core.models.InstanceSourceViaImageDetails(
image_id=image_id,
boot_volume_size_in_gbs=disk_size_gb,
),
)
).data

Expand Down

0 comments on commit a3c27ff

Please sign in to comment.