More flexible OCI credentials configuration #1289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- In client credentials, replace the key path with the key content to allow configuring without any file paths - In default credentials, allow overriding the config file path and choosing a profile from the config file This is part of the OCI backend implementation. Behind the OCI_BACKEND feature flag.
r4victor
reviewed
May 31, 2024
r4victor
approved these changes
May 31, 2024
jvstme
added a commit
that referenced
this pull request
Jun 4, 2024
This fixes some issues introduced by PR #1289: - Fix unit tests - Do not you pathlib.Path in credentials model, as it is rendered incorrectly in YAML
jvstme
added a commit
that referenced
this pull request
Jun 4, 2024
This fixes some issues introduced by PR #1289: - Fix unit tests - Do not use pathlib.Path in credentials model, as it is rendered incorrectly in YAML
jvstme
added a commit
that referenced
this pull request
Jun 4, 2024
This fixes some issues introduced by PR #1289: - Fix unit tests - Do not use pathlib.Path in credentials model, as it is rendered incorrectly in YAML
Bihan
pushed a commit
to SMTM-Capital/dstack
that referenced
this pull request
Jun 11, 2024
This fixes some issues introduced by PR dstackai#1289: - Fix unit tests - Do not use pathlib.Path in credentials model, as it is rendered incorrectly in YAML
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the OCI backend implementation (#1194). Behind the OCI_BACKEND feature flag.