Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CUDO Compute backend #928

Merged
merged 10 commits into from
Mar 7, 2024
Merged

Add CUDO Compute backend #928

merged 10 commits into from
Mar 7, 2024

Conversation

Bihan
Copy link
Contributor

@Bihan Bihan commented Feb 25, 2024

No description provided.

r4victor
r4victor reviewed Feb 26, 2024
View reviewed changes
Copy link
Collaborator

@r4victor r4victor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM.

@peterschmidt85 peterschmidt85 changed the title Add cudo Add CUDO Compute backend Feb 27, 2024
@Bihan
Copy link
Contributor Author

Bihan commented Feb 28, 2024

@TheBits Looks like cudocompute's service is not working properly now. Once it is up I will test and update the pull request.

@peterschmidt85
Copy link
Contributor

Looks like cudocompute's service is not working properly now. Once it is up I will test and update the pull request.

@Bihan Did you contact their support? Would be great to know what was the problem.

@Bihan
Copy link
Contributor Author

Bihan commented Feb 28, 2024

Looks like cudocompute's service is not working properly now. Once it is up I will test and update the pull request.

@Bihan Did you contact their support? Would be great to know what was the problem.

@peterschmidt85 Not yet I will message them.

@TheBits
Copy link
Contributor

TheBits commented Mar 1, 2024

@Bihan, hi!

Please fix the test src/tests/_internal/server/routers/test_backends.py::TestListBackendTypes::test_returns_backend_types.
I will merge this PR.

Details about failed test https://github.com/dstackai/dstack/actions/runs/8093259417/job/22135160524?pr=928

@Bihan
Copy link
Contributor Author

Bihan commented Mar 1, 2024

@TheBits What should I do for this gateway-build failure https://github.com/dstackai/dstack/actions/runs/8109849691/job/22169262925?pr=928

@TheBits TheBits self-assigned this Mar 6, 2024
@TheBits TheBits merged commit fafc867 into dstackai:master Mar 7, 2024
11 of 15 checks passed
TheBits added a commit that referenced this pull request Mar 7, 2024
@Bihan @TheBits
Add CUDO Compute backend (#928)
2d61aaa 
* Added Cudocompute

* Changed to Cudo From CudoCompute

* Add BackendInvalidCredentialsError handling for cudo

* Update gpuhunt to 0.0.6

---------

Co-authored-by: Bihan  Rana <bihan@Bihans-MacBook-Pro.local>
Co-authored-by: Sergey Mezentsev <sergeyme@dstack.ai>
@Bihan Bihan deleted the add_cudo branch April 10, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheBits TheBits TheBits left review comments

@r4victor r4victor r4victor left review comments

Assignees

@TheBits TheBits

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Bihan @peterschmidt85 @TheBits @r4victor