Feature/expiry #44
Open
Feature/expiry #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey thanks for your PR. I'll review it and merge it. Unfortunately I'm a little short in time right now, but I'll get to it as soon as possible. |
|
Looks good. |
|
@sgyurko I'd also like to preserve the existing behavior in case nothing is defined. Can you make the initial expiry value -1 or something like that, meaning the records don't expire at all? I'm thinking about users that just pull this image on a regular basis and don't expect the configured behavior to change unless they explicitly opt in? |
|
I agree. Default behavior shouldn't change if possible. (And pretty sure it's possible) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented resource expiry (as one of your feature request was open for some time).
Can you please review and comment?