This repository has been archived by the owner on Nov 26, 2020. It is now read-only.
Ignore filesystems that we can't access in the freespace plugin #130
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
DSTAT VERSION
All versions
SUMMARY
When using the
freespace
plugin and running as a non-privileged user, if any of the filesystems listed inmtab
is not accessible due to permissions, the plugin will entirely fail and return no data.With this fix at least the system will ignore those filesystems and display the other ones, right now it shows no output to say that an endpoint might not be accessible, maybe a warning on
stderr
would be useful?Before
After