can build models and types using tsc #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsternlicht
requested changes
Jan 8, 2022
|
My rationale is that using the same build folder increases the size of a
live deployment without providing additional benefit.
I did consider calling the build folder “lib”, or something shorter, for
less wordy import paths. That would also be appropriate if we were to later
make the app available as a component library.
Thoughts?
|
|
I am considering changing this PR to make the entire app available as a library, instead of just the interfaces. Will submit update later today. |
|
That's actually makes much more sense. |
- build entire project, not just models
Done |
dsternlicht
approved these changes
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TSC build and types for config model