quick fix for VS2019/Qt 5.15 build #1
Conversation
|
fixed the QT_VERSION_STR Problem, added Ubuntu build instructions |
There was a problem hiding this comment.
Thanks for looking into this! I added a few review questions as I'm honestly out of the loop in how Qt has developed in the past decade. The original win32 builds were made with MinGW and a custom built Qt under Linux, using Gentoo's crossdev. The goal was to try to reduce the bloated binary sizes, but the results were unsatisfactory, so I'm not eager to repeat that cumbersome exercise.
| @@ -15,11 +15,13 @@ | |||
| // along with this program; if not, write to the Free Software | |||
| // Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. | |||
|
|
|||
| #include <windows.h> | |||
There was a problem hiding this comment.
Why is this required? Should probably be wrapped in #if defined(Q_OS_WIN or similar to maintain portability.
There was a problem hiding this comment.
the opengl header is not working when not including windows.h
first problematic line in windows gl.h: WINGDIAPI void APIENTRY glAccum (GLenum op, GLfloat value);
#if defined (_MSC_VER) // needed for glu.h if build with MSVC
#include <windows.h>
#endif
There was a problem hiding this comment.
https://www.opengl.org//archives/resources/faq/technical/gettingstarted.htm
Also, note that you'll need to put an #include <windows.h> statement before the #include<GL/gl.h>. Microsoft requires system DLLs to use a specific calling convention that isn't the default calling convention for most Win32 C compilers, so they've annotated the OpenGL calls in gl.h with some macros that expand to nonstandard C syntax. This causes Microsoft's C compilers to use the system calling convention. One of the include files included by windows.h defines the macros.
| @@ -318,7 +319,7 @@ void MainWindow::about() | |||
| QMessageBox::about(this, tr("About stressed"), | |||
| tr("<div align=\"center\"><h1>%1 %2</h1><br/>" | |||
| "%3<br/>" | |||
| "Using Qt "QT_VERSION_STR"/%5<br/>" | |||
| "Using Qt 5.15/%5<br/>" | |||
There was a problem hiding this comment.
Can we still use QT_VERSION_STR as a numbered argument in the tr() format string? tr("Qt %1").arg(QT_VERSION_STR)
There was a problem hiding this comment.
you can keep it nearly like that - its not allowed in C++11 to write "QT_VERSION_STR"
you need to write " QT_VERSION_STR ", (blank before and after ")
gcc 9.3 warns (see #2), VS2019 just don't compiles the line without the blanks around, i'll fixed that in my second change
|
can you also add this line to my README Linux Build extension: sudo apt install libqt5opengl5-dev # needed for Mint 19.3, Ubuntu 18.04 |
|
Done and merged. Thanks! |
app.pro: Visual Studio creates different lib names (its possible to seperate the changes with
win32-msvc* {)shapemodel.cpp/shapeview.cpp: Some sort of Mirosoft Problem #define + cmath does not work for M_PI, #define + math.h works for M_PI but then the std-namespaces is gone