Add support for plugins #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svidal-dstl
requested review from
a team,
sdhiscocks and
oharrald-Dstl
and removed request for
a team
sdhiscocks
approved these changes
Feb 15, 2021
There was a problem hiding this comment.
Looks good, and I've tested with a dummy plugin.
One issue is this is lacking tests, but I'm not sure how we'd approach that, as the entry points would need to be present; maybe mock with monkeypatching. Suggest we raise this as separate issue for future change.
sdhiscocks
reviewed
Feb 15, 2021
sdhiscocks
reviewed
Feb 15, 2021
Co-authored-by: Steven Hiscocks <sdhiscocks@dstl.gov.uk>
Co-authored-by: Steven Hiscocks <sdhiscocks@dstl.gov.uk>
oharrald-Dstl
approved these changes
Feb 15, 2021
Codecov Report
@@ Coverage Diff @@
## master #375 +/- ##
==========================================
- Coverage 94.19% 94.08% -0.11%
==========================================
Files 132 133 +1
Lines 6145 6155 +10
Branches 890 891 +1
==========================================
+ Hits 5788 5791 +3
- Misses 257 263 +6
- Partials 100 101 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
PhilClemson
pushed a commit
to PhilClemson/Stone-Soup-1
that referenced
this pull request
Oct 26, 2021
Add support for plugins Closes dstl#356
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to load plugins using package metadata in package's setup.py entry_points. This will enable third party Stone Soup components to be easily discoverable.