Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with kD-tree example not building #807

Merged
merged 3 commits into from May 25, 2023
Merged

Conversation

sdhiscocks
Copy link
Member

Sometimes the build failed due to example taking too long to run. I've reduced the number of tracks in simulation, and avoided running simulation multiple times.

@sdhiscocks sdhiscocks requested a review from a team as a code owner May 24, 2023 11:57
@sdhiscocks sdhiscocks requested review from nperree-dstl and removed request for a team May 24, 2023 11:57
Copy link
Contributor

@rcgorman-dstl rcgorman-dstl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small suggestion to make code more readable but otherwise looks good. Tested with new params and TPR tree and KD tree both faster than linear still.

docs/tutorials/dataassociation/KDTree_Tutorial.py Outdated Show resolved Hide resolved
Co-authored-by: Roisín Gorman <119332214+rcgorman-dstl@users.noreply.github.com>
@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Patch coverage has no change and project coverage change: +4.44 🎉

Comparison is base (a4df8fd) 90.14% compared to head (35ac949) 94.58%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #807      +/-   ##
==========================================
+ Coverage   90.14%   94.58%   +4.44%     
==========================================
  Files         184      184              
  Lines       10698    10698              
  Branches     2176     2176              
==========================================
+ Hits         9644    10119     +475     
+ Misses        857      398     -459     
+ Partials      197      181      -16     
Flag Coverage Δ
integration 69.62% <ø> (?)
unittests 90.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 31 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sdhiscocks sdhiscocks merged commit 8448405 into main May 25, 2023
9 checks passed
@sdhiscocks sdhiscocks deleted the kdtree_tutorial_doc_fix branch May 25, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants