Regulariser amendment and implementation in ParticleUpdater #830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto the base ParticleUpdater
…operty of MCMCRegulariser()
timothy-glover
requested review from
nperree-dstl and
rcgorman-dstl
and removed request for
a team
sdhiscocks
reviewed
Aug 2, 2023
stonesoup/regulariser/particle.py
Outdated
Comment on lines
32
to
35
| transition_model: TransitionModel = Property(doc="Transition model used for prediction") | ||
|
|
||
| def regularise(self, prior, posterior, detections): | ||
| """Regularise the particles |
There was a problem hiding this comment.
Could you also pass an optional transition model, using the hypothesis.prediction.transition_model, from the updater, and falling back to provide one (on self) if not provided. Possibly via **kwargs or even passing hypothesis instead?
nperree-dstl
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prior used for the
MCMCRegularisershould be projected through time without the inclusion of noise. To do this,transition_modelhas been added as a property of the MCMCRegulariser. The transition model is used to propagate the prior particles at the beginning of theregularise()method. The support for lists of typeParticlehas also been dropped to allow for the calculation of the time interval in theregularise()method.