Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added dockerfiles #53

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

antjkennedy
Copy link

  • Dockerfile added for building the project
  • docker-compose.yml added to support example
  • simple example configs added for convenience

* Dockerfile added for building the project
* docker-compose.yml added to support example
* simple example configs added for convenience
@jamesdbaker
Copy link
Contributor

The Dockerfile works fine, and whilst I haven't tested the docker-compose or configs they look like they should work too.

However, I'd suggest changing how the Docker aspects are documented, perhaps adding a separate file or a separate section to the README explaining how to build and use them, rather than mixing it in with the existing documentation. I think it also needs some rewording as well - at the moment, it reads like you have to run Docker Baleen via the example docker-compose.yml with the example pipeline; rather than that just being an example and actually it is run with

docker build -t baleen:2.4.1-SNAPSHOT .
docker run -d -p 6413:6413 baleen:2.4.1-SNAPSHOT

@rixsonm-dstl
Copy link

This PR looks fine, can the documentation be updated as requested above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants