Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors trying to install in Crostini #22

Closed
tbuckley opened this issue Jan 1, 2023 · 2 comments
Closed

Errors trying to install in Crostini #22

tbuckley opened this issue Jan 1, 2023 · 2 comments

Comments

@tbuckley
Copy link

tbuckley commented Jan 1, 2023

Following the steps in README.md using Crostini, I ran into a couple errors. I haven't been able to move past the second so far.

  1. make was missing, so I ran sudo apt install build-essential

  2. There appears to be an issue with tree-sitter-markdown and nan, which might be nan_callbacks.h:55:23: error: ‘AccessorSignature’ is not a member of ‘v8’ nodejs/nan#942:

npm ERR! > tree-sitter-markdown@0.1.1 install
[...skipped]
npm ERR! In file included from ../node_modules/nan/nan.h:180,
npm ERR!                  from ../bindings/node/binding.cc:3:
npm ERR! ../node_modules/nan/nan_callbacks.h:55:23: error: ‘AccessorSignature’ is not a member of ‘v8’
npm ERR!    55 | typedef v8::Local<v8::AccessorSignature> Sig;
npm ERR!       |                       ^~~~~~~~~~~~~~~~~
npm ERR! ../node_modules/nan/nan_callbacks.h:55:40: error: template argument 1 is invalid
npm ERR!    55 | typedef v8::Local<v8::AccessorSignature> Sig;
npm ERR!       |     

Per the issue, I tried resolving this by adding the following to package.json, but it doesn't seem to do the trick

"scripts" {
  // ...
  "preinstall": "npx npm-force-resolutions"
},
"resolutions": {
  "nan": "2.17.0"
}
@dstoc
Copy link
Owner

dstoc commented Jan 5, 2023

What is node --version?

This works for me with v18.12.1. I installed that using https://github.com/nodesource/distributions#using-ubuntu-4

There is one other step missing from README.md, after cloning the repo we need to run git submodule update --init --recursive but it shouldn't cause the above issue.

@tbuckley
Copy link
Author

tbuckley commented Jan 9, 2023

node --version is v19.4.0 (installed via nvm install stable)
npm --version is 9.2.0

I switched node to 18.12.1 (and npm 8.19.2) using nvm, and could not reproduce the error :-/

@dstoc dstoc closed this as completed Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants