-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MQ constants in one namespace #203
Conversation
From: https://github.com/dsuch/pymqi/issues/204#issuecomment-649025659 @dsuch @JochemGit Shall we just import all the constants in |
I would rather keep them separate - this will amount to hundreds of names in the namespace, making code completion more cumbersome. |
Do it as @dsuch likes it. I am fine with it. |
@JochemGit Do you mind making the change |
@AlexandreYang I chose the name in analogy to the java class MQConstants, which implements the interfaces CMQC, CMQCFC, CMQXC, CMQZC and some others. |
Dear PyMQI champions, I ask, let it be const without discussing it further - there is no real difference between all these names, I just chose it in compliance with my own programming conventions. Thanks a lot. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. It will be indeed more convenient to use constants within a single namespace.
@AlexandreYang There is nothing that I can think of to prevent a new release, I will do it soon. |
Thanks. |
As discussed in this issue I created a file
mqconstants.py
to provide all MQ constants in namespacepymqi.mqconstants
.Additionally I added an import in
__init__.py
. It works for me. It should not affect anything else.