'connect_with_options': apply 'ensure_bytes' to 'cd' and 'sco' #303
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In function 'connect_with_options', the code applies 'ensure_bytes' to parameter 'name', so a python 3 string value is allowed here.
The same is not done for attributes of parameters 'cd' or 'sco'.
When passing in 'cd' / 'sco' which's attributes are python 3 string values, I run into this error:
TypeError: Python 3 style string (unicode) found but not allowed here
Please kindly review this PR and let me know whether it is ok, thanks a lot!
Really appreciate the great work in this library!