Rewrite to use Crypt::OpenSSL::Guess

[michal-josef-spacek]

Implementation of #97
Crypt::OpenSSL::Guess has support for all use cases implemented in this Makefile.PL

[skaji]

Makefile.PL is an auto generated file.
So you may want to edit maint/Makefile_header.PL and cpanfile.

[skaji]

LIBS => ['-lssl -lcrypto '.openssl_lib_paths()],

should be

LIBS => [openssl_lib_paths() . ' -lssl -lcrypto'],

cf akiym/Crypt-OpenSSL-Guess#12

[michal-josef-spacek]

@skaji Fixed

[skaji]

CONFIGURE_REQUIRES Crypt::OpenSSL::Guess should be specified by cpanfile.

[michal-josef-spacek]

@skaji ok, I updated cpanfile, test dzil build. Thanks.

[skaji]

The change looks good to me.

Note:
Before merging this PR, we should support openssl v3 because Crypt::OpenSSL::Guess may select openssl v3.

[michal-josef-spacek]

@skaji Same sitation with OpenSSL 3 was before.

[michal-josef-spacek]

@skaji Your #100 with -DOPENSSL_API_COMPAT=0x10000000L is working for me. I tested unit tests on OpenSSL 3.0.1 and 1.1.1l

[mmcclimon]

+1 to this PR. I couldn't install after messing around with my openssl libs, and applying this patch got me up and running.

[jonasbn]

Thanks for the feedback @mmcclimon. Easter holiday is coming up, I hope I can get it reviewed and merged and released

[jonasbn]

LGTM, approved

[jonasbn]

Thanks @michal-josef-spacek for the PR and thanks @skaji and @mmcclimon for review and test

[jonasbn]

I have marked this as solving #97 a TRIAL release, well let us know if this works out as expected, else we will just reopen #97

[jonasbn]

Hi @skaji, @michal-josef-spacek and @mmcclimon

This has been included in the release 1.9.14-TRIAL, just uploaded to PAUSE/CPAN.

Please let me know if you experience any issues or have any feedback. The 1.9.14 release will be made in due time depending on the outcome/feedback of the trial release.

Thanks for your contributions.

[mmcclimon]

Works for me, thanks!