Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate srt? #1

Closed
ltworf opened this issue Oct 11, 2022 · 2 comments
Closed

Generate srt? #1

ltworf opened this issue Oct 11, 2022 · 2 comments

Comments

@ltworf
Copy link

ltworf commented Oct 11, 2022

Hello,

This is very similar to something I was planning to do.

Wouldn't it be better to generate .srt files instead? So one can manually adjust the errors, fix the size, disable them and so on.

If you want a single file you can separately make a .mkv file and add a subtitle track.

@dsymbol
Copy link
Owner

dsymbol commented Oct 11, 2022

It generates srt files by default I just feel like the main point of this script is burning them in, to force them.

Feel free to fork and create your own version of it though.

Edit: on second thought adjusting the errors does sound like a very important feature I might to implement this as a cli argument, something like --no-burn

@ltworf
Copy link
Author

ltworf commented Oct 14, 2022

Yeah well I've started to implement my own.

I've realised it's good only for a rough initial version but needs manual fixing.

https://github.com/ltworf/srtgen

@ltworf ltworf closed this as completed Oct 14, 2022
dsymbol added a commit that referenced this issue Oct 18, 2022
dsymbol added a commit that referenced this issue Feb 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants