Use []byte("...") instead of []byte{...}. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This approach fares more favorable in a number of resource consumption dimensions: • an 11M input file results in 41M instead of 61M of Go source • compilation uses a few megabytes instead of gigabytes of RAM • compilation time is reduced from 25s to <1s I verified correctness by printing the md5 checksum of the file compiled with the previous commit and this commit; they match. The startup overhead of the string conversion is not measurable on my machine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This approach fares more favorable in a number of resource consumption
dimensions:
• an 11M input file results in 41M instead of 61M of Go source
• compilation uses a few megabytes instead of gigabytes of RAM
• compilation time is reduced from 25s to <1s
I verified correctness by printing the md5 checksum of the file compiled
with the previous commit and this commit; they match. The startup
overhead of the string conversion is not measurable on my machine.