Skip to content

Commit

Permalink
ack_filter: fix TCP flag check
Browse files Browse the repository at this point in the history
SYNs could theoretically have been filtered, which should not happen
regardless of how weird the behaviour would be to trigger this case.

Signed-off-by: Ryan Mounce <ryan@mounce.com.au>
  • Loading branch information
rmounce committed Jan 7, 2018
1 parent 31277c2 commit 8cf5278
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion sch_cake.c
Expand Up @@ -1012,7 +1012,7 @@ static struct sk_buff *cake_ack_filter(struct cake_sched_data *q,
* must be 'pure' ACK, contain zero bytes of segment data
* options are ignored
*/
if ((tcp_flag_word(tcph) &
if ((tcp_flag_word(tcph_check) &
(TCP_FLAG_ACK | TCP_FLAG_SYN)) != TCP_FLAG_ACK) {
continue;
} else if (((tcp_flag_word(tcph_check) &
Expand Down

0 comments on commit 8cf5278

Please sign in to comment.