Skip to content
Permalink
Browse files

ack_filter: fix TCP flag check

SYNs could theoretically have been filtered, which should not happen
regardless of how weird the behaviour would be to trigger this case.

Signed-off-by: Ryan Mounce <ryan@mounce.com.au>
  • Loading branch information
rmounce committed Jan 7, 2018
1 parent 31277c2 commit 8cf5278c665e1545b8f0169324b32a6f757a426d
Showing with 1 addition and 1 deletion.
  1. +1 −1 sch_cake.c
@@ -1012,7 +1012,7 @@ static struct sk_buff *cake_ack_filter(struct cake_sched_data *q,
* must be 'pure' ACK, contain zero bytes of segment data
* options are ignored
*/
if ((tcp_flag_word(tcph) &
if ((tcp_flag_word(tcph_check) &
(TCP_FLAG_ACK | TCP_FLAG_SYN)) != TCP_FLAG_ACK) {
continue;
} else if (((tcp_flag_word(tcph_check) &

0 comments on commit 8cf5278

Please sign in to comment.
You can’t perform that action at this time.