Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ruby 3.0 & 3.1 #19

Merged
merged 13 commits into from
Dec 27, 2022

Conversation

philip-maina
Copy link
Contributor

Summary

This adds support for Ruby 3.0 and 3.1. It builds off of this pull request.

Highlights

  1. Fixes separation of positional arguments from keyword arguments in ActsAsHashids::Core::ClassMethods#has_many

  2. Upgrades rubocop to ~> 0.81.0. This was necessitated by two things.

    • Ruby 3.1 ships with psych 4.0 by default whose #safe_load method now accepts both positional and keyword arguments. This results in an ArgumentError when calling Rubocop::ConfigLoader.yaml_safe_load.
    • Calling Rubocop::ConfigLoaderResolver#merge in Rubocop::ConfigLoaderResolver#merge_with_default results in an ArgumentError because opts should now be passed as a keyword argument.
  3. Upgrades the least required ruby version to 2.3.0 since this is the least required Ruby version by rubocop, '~> 0.81.0'.

Copy link
Owner

@dtaniwaki dtaniwaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dtaniwaki dtaniwaki merged commit c40e88a into dtaniwaki:master Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants