Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support kustomize-load-restrictor flag #1

Conversation

dosferatu
Copy link
Contributor

Summary of changes:

  • Add support for the --kustomize-load-restrictor flag that lets you set the LoadRestrictions option when running build/diff for the given kustomization provider (embedded or external via --kustomize-path)
  • Update the README for the new help output
  • Add tests for build + diff using the new LoadRestrictions option passthrough
  • Add the git-kustomize-diff binary to .gitignore

@dosferatu dosferatu force-pushed the dosferatu/kustomize-embed-option-passthrough branch 2 times, most recently from 3b1806e to 8a350cc Compare May 7, 2023 00:59
@dosferatu dosferatu force-pushed the dosferatu/kustomize-embed-option-passthrough branch from 8a350cc to 2d62e03 Compare May 7, 2023 01:00
@rattboi
Copy link

rattboi commented May 17, 2023

@dtaniwaki any way we could get eyes on this? @dosferatu and I are trying not to have to fork this project, and have other features we'd like to add after this.

Copy link
Owner

@dtaniwaki dtaniwaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!!

@@ -89,7 +91,8 @@ func init() {
runCmd.PersistentFlags().StringVar(&runOpts.target, "target", "", "target commitish (default to the current branch)")
runCmd.PersistentFlags().StringVar(&runOpts.includeRegexpString, "include", "", "include regexp (default to all)")
runCmd.PersistentFlags().StringVar(&runOpts.excludeRegexpString, "exclude", "", "exclude regexp (default to none)")
runCmd.PersistentFlags().StringVar(&runOpts.kustomizePath, "kustomize-path", "", "path of a kustomize binary (default to embeded)")
runCmd.PersistentFlags().StringVar(&runOpts.kustomizePath, "kustomize-path", "", "path of a kustomize binary (default to embedded)")
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇

@dtaniwaki dtaniwaki merged commit 8f449c1 into dtaniwaki:main Sep 7, 2023
@dtaniwaki
Copy link
Owner

Sorry for the late reply. I released v0.2.0 just now!

@dosferatu dosferatu deleted the dosferatu/kustomize-embed-option-passthrough branch September 8, 2023 05:21
@dosferatu
Copy link
Contributor Author

Sorry for the late reply. I released v0.2.0 just now!

No worries @dtaniwaki we were glad you’d started on a tool like this in the first place. Thanks for taking a look at this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants