Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-6 Fix setting name #7

Merged
merged 1 commit into from
Dec 22, 2014
Merged

GH-6 Fix setting name #7

merged 1 commit into from
Dec 22, 2014

Conversation

dtaniwaki
Copy link
Owner

Use setting name which is easily understandable.

@@ -6,8 +6,8 @@ class Mandriller::Base < ActionMailer::Base
include Mandriller::SettingsMethods

BOOLEAN_SETTINGS = {
autotext: 'X-MC-Autotext',
autohtml: 'X-MC-AutoHtml',
auto_text: 'X-MC-Autotext',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 4dfca3f on fix-setting-name into 5133208 on master.

dtaniwaki added a commit that referenced this pull request Dec 22, 2014
@dtaniwaki dtaniwaki merged commit 807d181 into master Dec 22, 2014
@dtaniwaki dtaniwaki deleted the fix-setting-name branch December 22, 2014 02:29
@PikachuEXE
Copy link

This is a breaking change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants