Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not play well with New Relic yaml config files. ' vs ". #15

Closed
cziko opened this issue Feb 5, 2013 · 9 comments
Closed

Does not play well with New Relic yaml config files. ' vs ". #15

cziko opened this issue Feb 5, 2013 · 9 comments

Comments

@cziko
Copy link

cziko commented Feb 5, 2013

For some reasons values in ' ' do not work properly whereas values in " " are fine. Both ' and " are valid in terms of YAML specs.

@dtao
Copy link
Owner

dtao commented Feb 5, 2013

Could you provide a sample config file and also indicate which version of Ruby and safe_yaml you're using? The gem is meant to handle single and double quotes the same, so this must just be a case that is currently overlooked.

@cziko
Copy link
Author

cziko commented Feb 5, 2013

@cziko
Copy link
Author

cziko commented Feb 5, 2013

Btw after changing ' ' to " " in sandbox env everything worked just fine.

@dtao
Copy link
Owner

dtao commented Feb 6, 2013

Sorry for being dense—could you explain exactly what is wrong about the output when you leave the single quotes in there?

I think I see the problem you're encountering: basically, the environment's explicit values are not taking precedence over the default settings. Is that right? If so, I see the problem and know how to fix it; but I want to make sure this is the problem you're reporting as opposed to something else.

Incidentally, if this is what you're referring to, it is actually not related to single vs. double quotes, but rather to non-deterministic enumeration of hash keys.

@knowak
Copy link

knowak commented Feb 6, 2013

That's what he's been referring to, yes.

@cziko
Copy link
Author

cziko commented Feb 6, 2013

Yes, that's the underlying issue. Sorry - late night bug report :/.

@cziko
Copy link
Author

cziko commented Feb 6, 2013

Thanks for the fix.

@nazgob
Copy link

nazgob commented Feb 6, 2013

@dtao works, thanks!

@dtao
Copy link
Owner

dtao commented Feb 6, 2013

Sweet! OK then, closing

@dtao dtao closed this as completed Feb 6, 2013
ota42y pushed a commit to ota42y/safe_yaml that referenced this issue Aug 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants
@nazgob @cziko @dtao @knowak and others