Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove limitation when applying GRIB ensemble filter configuration options. #1604

Closed
8 of 21 tasks
JohnHalleyGotway opened this issue Dec 9, 2020 · 1 comment · Fixed by #1608 or #1609
Closed
8 of 21 tasks

Remove limitation when applying GRIB ensemble filter configuration options. #1604

JohnHalleyGotway opened this issue Dec 9, 2020 · 1 comment · Fixed by #1608 or #1609
Assignees
@JohnHalleyGotway
Labels
MET: Library Code reporting: DTC NOAA R2O NOAA Research to Operations DTC Project requestor: NOAA/EMC NOAA Environmental Modeling Center type: enhancement Improve something that it is currently doing
Projects
MET-10.0.0-beta3 (1/27/21)
Milestone
MET 10.0.0

Comments

@JohnHalleyGotway
Copy link
Collaborator

JohnHalleyGotway commented Dec 9, 2020 •
edited

Describe the Enhancement

This requested change to the logic arose via met-help:
https://rt.rap.ucar.edu/rt/Ticket/Display.html?id=97769

Binbin is trying to filter out a single record from a GRIB1 ECMWF data file. MET does include a GRIB_ens configuration option which should be used in this case. However, the GRIB_ens logic is currently only applied to NCEP produced data. This task is to remove the check in data2d_grib_utils.cc that prevents this filtering logic from applied to non-NCEP behavior.

In met-9.1, whenever the user specifies the "GRIB_ens" option, apply it to the data regardless of the center and subcenter numbers.

I was also surprised not to see a warning message about matching multiple records. Compare the GRIB1 log messages with those from GRIB2 and make them consistent when you unexpectedly match multiple records.

Also ensure that this change does not change the output from the nightly build.

Describe the steps to demonstrate this:
1. Pull sample data:

wget ftp://ftp.rap.ucar.edu/incoming/irap/met_help/zhou_data_20201208/ensposte.t00z.z500hr

2. With met-9.1, run:

plot_data_plane ensposte.t00z.z500hr plot.ps '*name="HGT"; level="P500"; lead_time="00"; GRIB_ens="low_res_ctl";*' -v 3

3. Note that it matched 51 records, but should only match 1 of them... record 26.

Time Estimate

2 days to test and fix.

Sub-Issues

Consider breaking the enhancement down into sub-issues.
No sub-issues required.

Relevant Deadlines

Include in met-10.0.0.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required: John HG
  • Select scientist(s) or no scientist required: Binbin for testing

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Review projects and select relevant Repository and Organization ones or add "alert:NEED PROJECT ASSIGNMENT" label
  • Select milestone to relevant bugfix version

Define Related Issue(s)

Consider the impact to the other METplus components.

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s), Project(s), Milestone, and Linked issues
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@JohnHalleyGotway JohnHalleyGotway added type: bug Fix something that is not working component: library code requestor: NOAA/EMC NOAA Environmental Modeling Center labels Dec 9, 2020
@JohnHalleyGotway JohnHalleyGotway added this to the MET 9.1.2 (bugfix) milestone Dec 9, 2020
@JohnHalleyGotway JohnHalleyGotway self-assigned this Dec 9, 2020
@JohnHalleyGotway JohnHalleyGotway added this to To do in METplus Version 3.1 Support via automation Dec 9, 2020
@JohnHalleyGotway JohnHalleyGotway changed the title Remove limitation for when GRIB ensemble filter configuration options are checked. Remove limitation when applying GRIB ensemble filter configuration options. Dec 9, 2020
JohnHalleyGotway added a commit that referenced this issue Dec 9, 2020
@JohnHalleyGotway
Per #1604, update the logic for the is_prelim_match() function for GR…
bc7c485 
…IB1 data. Instead of only processing the ensemble config options for NCEP data (center = 7, subcenter = 2), apply them anytime the user has supplied them.
@JohnHalleyGotway JohnHalleyGotway added type: enhancement Improve something that it is currently doing and removed type: bug Fix something that is not working labels Dec 14, 2020
@JohnHalleyGotway JohnHalleyGotway added this to To do in MET-10.0.0-beta3 (1/27/21) via automation Dec 14, 2020
@JohnHalleyGotway
Copy link
Collaborator Author

Switched from a bugfix type issue to an enhancement. Binbin confirmed that including this fix in met-10.0.0-beta3 is sufficient. We do not need a met-9.1.2 bugfix release for this change.

JohnHalleyGotway added a commit that referenced this issue Dec 14, 2020
@JohnHalleyGotway
Per #1604, removing the ensemble GRIB filtering limits for the develo…
92b57db 
…p branch.
JohnHalleyGotway added a commit that referenced this issue Dec 14, 2020
@JohnHalleyGotway
Per #1604, update logic in MetGrib1DataFile::data_plane() to print a …
122ee74 
…warning message when multiple matching records are found, even for pressure or vertical level types.
@JohnHalleyGotway JohnHalleyGotway linked a pull request Dec 14, 2020 that will close this issue
Feature 1604 ens_config #1608
Merged
8 tasks
jprestop pushed a commit that referenced this issue Dec 14, 2020
@JohnHalleyGotway
Feature 1604 ens_config (#1608)
0a18e89 
* Per #1604, removing the ensemble GRIB filtering limits for the develop branch.

* Per #1604, update logic in MetGrib1DataFile::data_plane() to print a warning message when multiple matching records are found, even for pressure or vertical level types.
JohnHalleyGotway added a commit that referenced this issue Dec 15, 2020
@JohnHalleyGotway
Per #1604, the Fortify run revealed two issues with these changes... …
9fe31da 
…the introduction of a memory leak and a variable that was set but never used. Minor updates to address these findings.
JohnHalleyGotway added a commit that referenced this issue Dec 15, 2020
@JohnHalleyGotway
Per #1604, resolving conflicts with develop.
cc8ba26
@JohnHalleyGotway JohnHalleyGotway linked a pull request Dec 15, 2020 that will close this issue
Feature 1604 ens_config second try #1609
Merged
8 tasks
jprestop pushed a commit that referenced this issue Dec 15, 2020
@JohnHalleyGotway
Feature 1604 ens_config second try (#1609)
d832593 
* Per #1604, removing the ensemble GRIB filtering limits for the develop branch.

* Per #1604, update logic in MetGrib1DataFile::data_plane() to print a warning message when multiple matching records are found, even for pressure or vertical level types.

* Per #1604, the Fortify run revealed two issues with these changes... the introduction of a memory leak and a variable that was set but never used. Minor updates to address these findings.
MET-10.0.0-beta3 (1/27/21) automation moved this from To do to Done Jan 11, 2021
@TaraJensen TaraJensen added the reporting: DTC NOAA R2O NOAA Research to Operations DTC Project label Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JohnHalleyGotway JohnHalleyGotway

Labels
MET: Library Code reporting: DTC NOAA R2O NOAA Research to Operations DTC Project requestor: NOAA/EMC NOAA Environmental Modeling Center type: enhancement Improve something that it is currently doing
Projects
No open projects
MET-10.0.0-beta3 (1/27/21)
  
Done
Milestone
MET 10.0.0
Development

Successfully merging a pull request may close this issue.

Feature 1604 ens_config dtcenter/MET
Feature 1604 ens_config second try dtcenter/MET
2 participants
@JohnHalleyGotway @TaraJensen