Add entries to the default obs_prepbufr_map setting.

[JohnHalleyGotway]

Describe the Enhancement

This is a very quick and easy fix that was discussed at length in this METplus Discussion METplus/dtcenter#1417.

The resolution is that we should 2 additional entries to the obs_prepbufr_map PB2NC configuration option:

{ key = "HOVI"; val = "VIS"; },
{ key = "TOCC"; val = "TCDC"; },

This task is to update all instances of the obs_prepbufr_map config entry with these changes.

Time Estimate

1 hour.

Sub-Issues

Consider breaking the enhancement down into sub-issues.
None needed.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

• Select engineer(s) or no engineer required: @JohnHalleyGotway
• Select scientist(s) or no scientist required: Not needed

Labels

• Select component(s)
• Select priority
• Select requestor(s)

Projects and Milestone

• Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
• Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

• METplus, MET, METdatadb, METviewer, METexpress, METcalcpy, METplotpy
  No direct impacts.

Enhancement Checklist

See the METplus Workflow for details.

• Complete the issue definition above, including the Time Estimate and Funding Source.
• Fork this repository or create a branch of develop.
  Branch name: feature_<Issue Number>_<Description>
• Complete the development and test your changes.
• Add/update log messages for easier debugging.
• Add/update unit tests.
• Add/update documentation.
• Push local changes to GitHub.
• Submit a pull request to merge into develop.
  Pull request: feature <Issue Number> <Description>
• Define the pull request metadata, as permissions allow.
  Select: Reviewer(s) and Linked issues
  Select: Repository level development cycle Project for the next official release
  Select: Milestone as the next official version
• Iterate until the reviewer(s) accept and merge your changes.
• Delete your fork or branch.
• Close this issue.

[JohnHalleyGotway]

@hsoh-u I need some input from you on this issue. I'm trying to do two things here.

1. Add the 2 entries listed above to the obs_prepbufr_map setting in the default PB2NC config file.
2. Update the comments for the obs_bufr_map setting in all existing PB2NC config files to make them consistent.

My question is about the contents of the test/PB2NCConfig_pbl file. I would like to remove this obs_prepbufr_map entry and move the non-default settings over to the obs_bufr_map setting instead. But I have 2 questions about this.

1. The current setting maps both "D_DPT" and "TDO" to the SAME output "DPT". This seems like a bad idea. We wouldn't be able to differentiate between the raw TDO obs and the derived one in the output. Both would show up as DPT.
2. This maps "D_PBL" to "HPBL", but the default setting maps "D_PBL" to "PBL". Which one should we be using? Or should I keep "D_PBL -> PBL" in the obs_prepbufr_map and override that with "D_PBL -> HPBL" in the obs_bufr_map for this test?

[JohnHalleyGotway]

Actually @hsoh-u, I just made a decision and will request your review on the PR. The PB2NCConfig_pbl output is NOT actually used downstream. It's just an independent test of PB2NC. As such, it doesn't matter so much that D_DPT and TDO are both renamed to the same string. In fact, this is a good test to confirm that the obs_bufr_map settings actually do take precedence over the obs_prepbufr_map settings. Fingers crossed that my proposed changes produce exactly the same result.