Bugfix: Fix PB2NC to report accurate total observation counts in log messages

[georgemccabe]

This was discovered while going through the METplus tutorial first pb2nc example

Describe the Problem

Since MET 10.1, the incorrect total number of obs is reported in the logs. It looks like the total number is higher than the actual number of obs that are written to the output file.

Potential fixes (unverified):

1. It looks like n_derived_obs was added and included in the total count (n_file_obs + n_derived_obs), but n_file_obs is also incremented when n_derived_obs is on this line. Removing n_file_obs++ from this line may fix the issue?
2. There is a n_total_obs counter variable that is incremented but never used. Using this value in the log instead may produce the correct result.

Expected Behavior

The number of observations written to the NetCDF output file should match the number from the log noting the "Total observations retained or derived."

Environment

Describe your runtime environment:
1. Machine: (e.g. HPC name, Linux Workstation, Mac Laptop)
2. OS: (e.g. RedHat Linux, MacOS)
3. Software version number(s)

To Reproduce

Describe the steps to reproduce the behavior:
1. Go to the METplus tutorial first pb2nc example
2. Set the values from the instructions
3. Run the command (or something similar):

pb2nc \
${METPLUS_DATA}/met_test/data/sample_obs/prepbufr/ndas.t00z.prepbufr.tm12.20070401.nr \
tutorial_pb_run1.nc \
PB2NCConfig_tutorial_run1 \
-v 2

4. Confirm the log message looks like this:

DEBUG 2: Total observations retained or derived = 68870

5. Run again using pb2nc from MET 10.0.0 or earlier and confirm that the log message looks like this:

DEBUG 2: Total observations retained or derived = 52491

and the NetCDF output matches this number.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

2792542 NOAA Base

Define the Metadata

Assignee

• Select engineer(s) or no engineer required
• Select scientist(s) or no scientist required

Labels

• Select component(s)
• Select priority
• Select requestor(s)

Projects and Milestone

• Select Organization level Project for support of the current coordinated release
• Select Repository level Project for development toward the next official release or add alert: NEED PROJECT ASSIGNMENT label
• Select Milestone as the next bugfix version

Define Related Issue(s)

Consider the impact to the other METplus components.

• METplus, MET, METdataio, METviewer, METexpress, METcalcpy, METplotpy

Bugfix Checklist

See the METplus Workflow for details.

• Complete the issue definition above, including the Time Estimate and Funding Source.
• Fork this repository or create a branch of main_<Version>.
  Branch name: bugfix_<Issue Number>_main_<Version>_<Description>
• Fix the bug and test your changes.
• Add/update log messages for easier debugging.
• Add/update unit tests.
• Add/update documentation.
• Push local changes to GitHub.
• Submit a pull request to merge into main_<Version>.
  Pull request: bugfix <Issue Number> main_<Version> <Description>
• Define the pull request metadata, as permissions allow.
  Select: Reviewer(s) and Development issue
  Select: Organization level software support Project for the current coordinated release
  Select: Milestone as the next bugfix version
• Iterate until the reviewer(s) accept and merge your changes.
• Delete your fork or branch.
• Complete the steps above to fix the bug on the develop branch.
  Branch name: bugfix_<Issue Number>_develop_<Description>
  Pull request: bugfix <Issue Number> develop <Description>
  Select: Reviewer(s) and Development issue
  Select: Repository level development cycle Project for the next official release
  Select: Milestone as the next official version
• Close this issue.