Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix 1409 master_v9.1 non_madis_profiler #1488

Merged
merged 1 commit into from Sep 10, 2020

Conversation

hsoh-u
Copy link
Collaborator

@hsoh-u hsoh-u commented Sep 10, 2020

The data file is at dakota:/d3/personal/hsoh/data/RT-95865/acars.2020010_1700

@JohnHalleyGotway JohnHalleyGotway changed the title #1409 Check if there are missing variables and give the proper log message Bugfix 1409 master_v9.1 non_madis_profiler Sep 10, 2020
@JohnHalleyGotway JohnHalleyGotway added this to In progress in METplus Version 3.1 Support via automation Sep 10, 2020
@JohnHalleyGotway JohnHalleyGotway added this to the MET 9.1.1 (bugfix) milestone Sep 10, 2020
Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Performed the same tests as I did for #1483 and confirmed that instead of segfaulting, we now get a useful error message:

madis2nc acars.20200108_1700 acars.20200108_1700.nc
DEBUG 1: Reading MADIS File:	acars.20200108_1700
ERROR  : 
ERROR  : process_madis_acarsProfiles() -> Please check if the input is a ACARS Profiles.
ERROR  : 
WARNING:     missing variable: profileAirport
WARNING:     missing variable: profileTime
WARNING:     missing variable: trackLat
WARNING:     missing variable: trackLon
WARNING:     missing variable: obsTimeOfDay
WARNING:     missing variable: nLevelsDD
WARNING:     missing variable: nLevels

@JohnHalleyGotway JohnHalleyGotway merged commit 749c738 into master_v9.1 Sep 10, 2020
METplus Version 3.1 Support automation moved this from In progress to Done Sep 10, 2020
@hsoh-u hsoh-u deleted the bugfix_1409_master_non_madis_profiler branch January 19, 2021 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants