Bugfix 1715 pb2nc seg fault with pbl 91 #1718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 17, 2021 18:13
21 tasks
JohnHalleyGotway
added this to In progress
in METplus Version 3.1 Support
via automation
met/src/tools/other/pb2nc/pb2nc.cc
Outdated
| << " to " << tq_pres_min << " UV pressures: " << uv_pres_max | ||
| << " to " << uv_pres_min << (no_overlap ? " no overlap!" : " overlapping") << "\n"; | ||
| if( no_overlap ) { | ||
| mlog << Warning << method_name |
There was a problem hiding this comment.
Suggested change
| mlog << Warning << method_name | |
| mlog << Warning << "\n" << method_name |
met/src/tools/other/pb2nc/pb2nc.cc
Outdated
| if( no_overlap ) { | ||
| mlog << Warning << method_name | ||
| << "Can not combine TQ and UV records because of no overlapping.\n"; | ||
| mlog << Warning << " TQZ record count: " << tq_count |
There was a problem hiding this comment.
Suggested change
| mlog << Warning << " TQZ record count: " << tq_count | |
| << " TQZ record count: " << tq_count |
met/src/tools/other/pb2nc/pb2nc.cc
Outdated
| << " to " << uv_pres_min << (no_overlap ? " no overlap!" : " overlapping") << "\n"; | ||
| if( no_overlap ) { | ||
| mlog << Warning << method_name | ||
| << "Can not combine TQ and UV records because of no overlapping.\n"; |
There was a problem hiding this comment.
Suggested change
| << "Can not combine TQ and UV records because of no overlapping.\n"; | |
| << "Cannot combine TQ and UV records because of no pressure level overlap.\n" |
met/src/tools/other/pb2nc/pb2nc.cc
Outdated
| << "Can not combine TQ and UV records because of no overlapping.\n"; | ||
| mlog << Warning << " TQZ record count: " << tq_count | ||
| << ", UV record count: " << uv_count | ||
| << " common_levels: " << common_levels.n() << "\n"; |
There was a problem hiding this comment.
Suggested change
| << " common_levels: " << common_levels.n() << "\n"; | |
| << " common_levels: " << common_levels.n() << "\n\n"; |
| << ", next: " << prev_pqtzuv[0] << "\n"; | ||
| << " Can't interpolate because of same pressure levels. prev: " | ||
| << prev_pqtzuv[0] << ", cur: " << cur_pqtzuv[0] | ||
| << ", next: " << prev_pqtzuv[0] << "\n"; |
There was a problem hiding this comment.
Suggested change
| << ", next: " << prev_pqtzuv[0] << "\n"; | |
| << ", next: " << prev_pqtzuv[0] << "\n\n"; |
met/src/tools/other/pb2nc/pb2nc.cc
Outdated
| if ((prev_pqtzuv[0] == cur_pqtzuv[0]) || (next_pqtzuv[0] == cur_pqtzuv[0])) { | ||
| if ((nint(prev_pqtzuv[0]) == nint(cur_pqtzuv[0])) | ||
| || (nint(next_pqtzuv[0]) == nint(cur_pqtzuv[0])) | ||
| || (nint(prev_pqtzuv[0]) == nint(next_pqtzuv[0]))) { | ||
| mlog << Error << method_name |
There was a problem hiding this comment.
Suggested change
| mlog << Error << method_name | |
| mlog << Error << "\n" << method_name |
JohnHalleyGotway
approved these changes
Mar 18, 2021
There was a problem hiding this comment.
Made suggestions for minor edits to the log warning/error log messages that are changed by this PR.
I did test these changes on kiowa in /d1/projects/MET/MET_pull_requests/met-9.1.3/feature_1715/MET-bugfix_1715_pb2nc_seg_fault_with_pbl_91_into_main_v9.1.
I ran unit_pb2nc.xml and diffed the output with recent main_v9.1 NB output. There are no differences, so low risk of unintended consequences.
@malloryprow already tested this patch on the WCOSS Cray machine and confirmed that it fixes the bug.
After accepting minor edits, please merge these changes into main_v9.1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Testing
The segmentation fault on computing PBL. It happened on cray machine (9.1.1 & 9.1.2). The problem happens when the TQ records and the UV records are overlapping to interpolate.
Do these changes include sufficient documentation and testing updates? [No]
Will this PR result in changes to the test suite? [No]
If yes, describe the new output and/or changes to the existing output:
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s), Project(s), and Milestone
Summary of Updating